Skip to content

Comments

Re-enabled CT#450

Merged
skywojciechowskim merged 2 commits intomasterfrom
FreeTimeFixes
Feb 23, 2026
Merged

Re-enabled CT#450
skywojciechowskim merged 2 commits intomasterfrom
FreeTimeFixes

Conversation

@skywojciechowskim
Copy link
Contributor

@skywojciechowskim skywojciechowskim commented Feb 20, 2026

Summary: Re-enabled CT
Type: Fix
Test Plan: UT/CT, Fullstack
Jira: NO-JIRA

Copilot AI review requested due to automatic review settings February 20, 2026 12:47
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Pull request must be merged with a description containing the required fields,

Summary:
Type: Feature/Fix/Cleanup
Test Plan:
Jira:

If there is no jira releated to this change, please put 'Jira: NO-JIRA'.

Description can be changed by editing the top comment on your pull request and making a new commit.

Copilot AI reviewed Feb 20, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables the previously disabled Flush component test by adding missing wrapper expectations so it can run reliably again in the MediaPipeline component test suite.

Changes:

  • Re-enabled the flushAudioSourceSuccess component test (removed DISABLED_ prefix).
  • Added Glib/GStreamer wrapper expectations for audio sink type name and optional unref calls.
  • Adjusted flush expectations by removing a now-redundant strict gstObjectUnref(m_audioSink) expectation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 85.2%
Functions coverage stays unchanged and is: 92.5%

@github-actions
Copy link

github-actions bot commented Feb 23, 2026

Coverage statistics of your commit:
WARNING: Lines coverage decreased from: 85.2% to 85.1%
Functions coverage stays unchanged and is: 92.5%

@github-actions
Copy link

github-actions bot commented Feb 23, 2026

Coverage statistics of your commit:
Lines coverage stays unchanged and is: 85.1%
Functions coverage stays unchanged and is: 92.5%

@skywojciechowskim skywojciechowskim merged commit fc2f3fe into master Feb 23, 2026
62 of 63 checks passed
@skywojciechowskim skywojciechowskim deleted the FreeTimeFixes branch February 23, 2026 09:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@aczs aczs aczs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skywojciechowskim @aczs